REGR: write compressed pickle files with protocol=5 #39376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 24, 2021
jreback
changed the title
jreback
approved these changes
Jan 26, 2021
Co-authored-by: Simon Hawkins <[email protected]>
|
thanks @twoertwein |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 26, 2021
simonjayhawkins
pushed a commit
that referenced
this pull request
Jan 27, 2021
…=5 (#39428) Co-authored-by: Torsten Wörtwein <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why the change from #37056 fails in combination with
protocol=5and compression. @ig248An alternative fix would be to have
get_handleinsert a write buffer for all compressions (similar to #38728) to avoid if/else in format specificto_*